feat: support object style hooks #9634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
patak-dev
reviewed
Aug 14, 2022
|
This one it ready |
This was referenced Aug 14, 2022
patak-dev
reviewed
Aug 14, 2022
| } as Plugin['transform'] | ||
| } else { | ||
| return handler | ||
| } |
There was a problem hiding this comment.
Maybe it is worth extracting a helper for these three functions to avoid repeating the function or object handling?
patak-dev
reviewed
Aug 14, 2022
| } | ||
| } | ||
| await Promise.all(parallelPromises) | ||
| } |
There was a problem hiding this comment.
Neat. Not for this PR, but a helper like this one for hookSequential could be good too.
|
Looks great! I think we should merge this in 3.1 as you suggest. We shouldn't restrict the rollup version in a patch. It will also help plugin authors with their required ranges. |
zmrl010
added a commit
to boatproject/editor
that referenced
this pull request
Aug 17, 2022
based on recent [recent changes](rollup/rollup#4600) and upcoming [PR](vitejs/vite#9634)
patak-dev
approved these changes
Aug 21, 2022
csr632
reviewed
Sep 7, 2022
| await Promise.all([ | ||
| ...resolved | ||
| .getSortedPluginHooks('configResolved') | ||
| .map((hook) => hook(resolved)), |
There was a problem hiding this comment.
this inside the hook no loger points to the plugin object:
#10031
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Vite support for rollup/rollup#4600
Additional context
This PR should await rollup/rollup#4600 to get shipped and probably should release as a minor version bump.
Progress
Plugin format validation in dev? (e.g. missinghandleror not function etc.). We don't have it previously.configureServer,configResolved, etc).transformIndexHtml- feat: align object interface fortransformIndexHtmlhook #9669What is the purpose of this pull request?